Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dulwich checkout #358

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Fix dulwich checkout #358

merged 3 commits into from
Apr 14, 2022

Conversation

nickjalbert
Copy link
Contributor

@nickjalbert nickjalbert commented Apr 13, 2022 •
edited
Loading

Fixes #348

I did a little digging in dulwich and found that someone had seemingly fixed our checkout issue in a partially-unmerged pull request here. I wrote a regression test, ported their checkout() code into our utils, and now things seem to be working correctly.

Regression demo:

# regression test without my fix; should fail
git checkout baae07da1b5cd2da6518d394313670f146b448dc
agentos clear-cache -y
pytest tests/test_repo.py::test_repo_checkout_bug

# regression test should pass with my fix applied
git checkout nj_dulwich_fix_2
agentos clear-cache -y
pytest tests/test_repo.py::test_repo_checkout_bug

@nickjalbert nickjalbert requested a review from andyk April 13, 2022 16:54
@nickjalbert
Copy link
Contributor Author

@andyk ready for you to take a look!

andyk
andyk approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@andyk andyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyk andyk merged commit 20f113a into agentos-project:master Apr 14, 2022
@andyk andyk mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyk andyk andyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Our dulwich code can leave undesired files in the repo directory
2 participants
@nickjalbert @andyk